Fixed user/pass preferences save for "manual" proxy settings. #9843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an error in the following constants: PREF_PROXY_AUTO_USERNAME = "proxy.manual.username" PREF_PROXY_AUTO_PASSWORD = "proxy.manual.password" they should be set to "auto" and not "manual": PREF_PROXY_AUTO_USERNAME = "proxy.auto.username" PREF_PROXY_AUTO_PASSWORD = "proxy.auto.password" Changing the constants to the correct value now will fix the problem for future installations of the IDE but will produce an annoying side-effect for users upgrading from previous version of the IDE: they will lose their saved user and pass (because it was saved as "proxy.manual.*") and the IDE will suddenly stop working without any clear reason. To avoid this I've left the value to "proxy.manual.*" and removed the distinction from AUTO and MANUAL, so now we have only: PREF_PROXY_USERNAME = "proxy.manual.username" PREF_PROXY_PASSWORD = "proxy.manual.password" The corresponding textbox in the preference dialog will be filled based on the PROXY_TYPE selection.
|
✅ Build completed. Please test this code using one of the following: ⬇️ https://downloads.arduino.cc/javaide/pull_requests/arduino-PR-9843-BUILD-927-linux32.tar.xz ℹ️ The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network proxy user/pass in "manual" mode are not saved. This PR fixes the problem.
There was an error in the following constants:
they should be set to "auto" and not "manual":
BTW changing the constants to the correct value now will fix the problem for future installations of the IDE but will produce an annoying side-effect for users upgrading from previous version of the IDE: they will lose their saved user and pass (because it was saved as "proxy.manual.*") and the IDE will suddenly stop working without any clear reason.
To avoid this I've left the value to "proxy.manual.*" and removed the distinction from AUTO and MANUAL, so now we have only:
The corresponding textbox in the preference dialog will be filled based on the PROXY_TYPE selection.